test: handle undefined default_configuration #30465
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addaleax
approved these changes
Nov 13, 2019
richardlau
approved these changes
Nov 13, 2019
cjihrig
approved these changes
Nov 13, 2019
devnexen
approved these changes
Nov 13, 2019
BridgeAR
approved these changes
Nov 13, 2019
BridgeAR
added
the
author ready
trivikr
reviewed
Nov 13, 2019
codebytere
force-pushed
the
handle-unset-defaultconfiguration
branch
from
fe70071 to
7b72997
Compare
trivikr
approved these changes
Nov 13, 2019
jasnell
approved these changes
Nov 14, 2019
|
@trivikr your suggestion failed lint: are we fine for me to move back to the previous format? I could also do this: const buildType = process.config.target_defaults ?
process.config.target_defaults.default_configuration :
'Release';i'm fairly un-opinionated on this front ¯\_(ツ)_/¯ |
|
Sure, this format works const buildType = process.config.target_defaults ?
process.config.target_defaults.default_configuration :
'Release';I'd posted my review as a nit, suggesting it's optional. |
codebytere
force-pushed
the
handle-unset-defaultconfiguration
branch
from
7b72997 to
74cf1cd
Compare
trivikr
approved these changes
Nov 16, 2019
|
Landed in 70281ce |
codebytere
added a commit
that referenced
this pull request
Nov 18, 2019
PR-URL: #30465 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
BridgeAR
pushed a commit
that referenced
this pull request
Nov 19, 2019
PR-URL: #30465 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
targos
pushed a commit
that referenced
this pull request
Dec 1, 2019
PR-URL: #30465 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Closed
MylesBorins
pushed a commit
that referenced
this pull request
Dec 17, 2019
PR-URL: #30465 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
codebytere
added a commit
to electron/electron
that referenced
this pull request
Jan 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a check for
process.config.target_defaultsbeing undefined, as it is Electron's case, and ensures that thebuildTypeis set to a default value ofReleaseshould it not be defined.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes